Add cache clearing for created channels on buffer disconnection - #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way channel access resources are cleaned up when disconnecting (PVs) in the
slac_timing/buffer.pymodule. Instead of relying on Python's garbage collection, it now explicitly clears related channels from the CA cache, ensuring more reliable resource cleanup.Resource management improvements:
gc.collect()in the_disconnect_pvsmethod and replaced it with a new_clear_ca_cachemethod that explicitly removes caget-created channels for the buffer from the CA cache and clears their channels usingepics.ca.clear_channel.gcimport from the top of the file.